Fix of breaking change during module upgrade #88
Merged
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This move block fixes the breaking change that would occur in the case of an upgrade from previous module version to this one, that would cause the namespace where ESO is deployed to be destroyed and ESO to be redeployed: this action would cause issues on existing CRs that wouldn't be cleaned up without a clean undeployment
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Added moved block to fix the breaking change that would occur in the case of an upgrade from previous module version to this one, that would cause the namespace where ESO is deployed to be destroyed and ESO to be redeployed
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers